Improvement for comparision against fn #59798
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
r? @estebank |
| }; | ||
|
|
||
| if self.lookup_op_method(fn_sig.output(), | ||
| &[other_ty], |
There was a problem hiding this comment.
We could have another code branch for the case where both ty and other_ty are fns, so that you can suggest calling both of them, if their return types are the same.
|
I reflected the estebank's review. |
|
@bors r+ |
|
📌 Commit d01ac0d has been approved by |
bors
added
S-waiting-on-bors
Improvement for comparision against fn I try to add error message. related: #59488
|
☀️ Test successful - checks-travis, status-appveyor |
I try to add error message.
related: #59488